Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: split ai editor feature capabilities #3716

Merged
merged 4 commits into from
May 24, 2024
Merged

refactor: split ai editor feature capabilities #3716

merged 4 commits into from
May 24, 2024

Conversation

Ricbet
Copy link
Member

@Ricbet Ricbet commented May 24, 2024

Types

  • 🪚 Refactors

Background or solution

主要重构了 ai-editor.contribution 代码，之前是所有 ai editor 相关的 feature 能力都全写在了这里，不易维护。
现在重构成由每个单独的 feature 能力（如 code action、rename、inline-completion）等各自维护自己的 feature

Changelog

@Ricbet Ricbet requested review from erha19 and bytemain May 24, 2024 06:46
@railway-app Railway App
Copy link

railway-app bot commented May 24, 2024

This PR was not deployed automatically as @Ricbet does not have access to the Railway project.

In order to get automatic PR deploys, please add @Ricbet to the project inside the project settings page.

@Ricbet Ricbet self-assigned this May 24, 2024
@opensumi opensumi bot added ⚙️ refactor Refactor code 🎨 feature feature required labels May 24, 2024
@codecov Codecov
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 392 lines in your changes are missing coverage. Please review.

Project coverage is 55.41%. Comparing base (5f617c1) to head (36fab2c).

Files Patch % Lines
.../browser/widget/inline-chat/inline-chat.handler.ts 0.00% 185 Missing and 28 partials ⚠️
...browser/contrib/code-action/code-action.handler.ts 0.00% 59 Missing and 14 partials ⚠️
...b/inline-completions/inline-completions.handler.ts 0.00% 53 Missing and 7 partials ⚠️
...ative/src/browser/contrib/rename/rename.handler.ts 0.00% 33 Missing and 1 partial ⚠️
packages/ai-native/src/browser/index.ts 0.00% 6 Missing ⚠️
...ser/contrib/inline-completions/completeProvider.ts 0.00% 1 Missing ⚠️
...contrib/inline-completions/prompt/importedFiles.ts 0.00% 1 Missing ⚠️
...rowser/contrib/inline-completions/prompt/prompt.ts 0.00% 1 Missing ⚠️
...ntrib/inline-completions/prompt/similarSnippets.ts 0.00% 1 Missing ⚠️
...rc/browser/contrib/terminal/ai-terminal.service.ts 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3716      +/-   ##
==========================================
- Coverage   55.62%   55.41%   -0.21%     
==========================================
  Files        1527     1530       +3     
  Lines       92953    93306     +353     
  Branches    19099    19162      +63     
==========================================
+ Hits        51707    51710       +3     
- Misses      34190    34497     +307     
- Partials     7056     7099      +43
Flag Coverage Δ
jsdom 50.86% <0.00%> (-0.19%) ⬇️
node 15.55% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ricbet Ricbet merged commit 7596f43 into main May 24, 2024
12 checks passed
@Ricbet Ricbet deleted the refactor/ai-native-editor-feature-contribution branch May 24, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bytemain bytemain bytemain approved these changes

@erha19 erha19 Awaiting requested review from erha19

Assignees

@Ricbet Ricbet

Labels
🎨 feature feature required ⚙️ refactor Refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ricbet @bytemain